Re: [PATCH 5/6] tools lib traceevent: Add page_size field to pevent

From: Steven Rostedt
Date: Fri Apr 12 2013 - 21:26:55 EST


On Sat, 2013-04-13 at 10:17 +0900, Namhyung Kim wrote:

> >
> > I just want to know more about this patch before I ack it.
>
> The page size of traced system can be different than current system's
> because the recorded data file might be analyzed in a different machine.
> In this case we should use original page size of traced system when
> accessing the data file, so this information needs to be saved.

I understand that, it's just strange that it's not used anywhere in the
library, or the patch series (that I can find).

It would make more sense if another patch used this new interface. I'm
sure new code will, but the patch should be part of a patch series that
needs it.

Thanks,

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/