Re: [PATCH 1/2] hfs/hfsplus: Convert dprint to hfs_dbg
From: Hin-Tak Leung
Date: Sun Apr 14 2013 - 21:56:22 EST
--- On Mon, 15/4/13, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Mon, 2013-04-15 at 01:53 +0100,
> Hin-Tak Leung wrote:
> > --- On Mon, 8/4/13, Joe Perches <joe@xxxxxxxxxxx>
> > > Use a more current logging style.
> > I have been sitting on a patch which changes this part
> of the code to dynamic debugging, and it is much simplier.
> > #define dprint(flg, fmt, args...) \
> > - if (flg &
> DBG_MASK) \
> > -
> printk(fmt , ## args)
> > +
> pr_debug(fmt , ## args)
> This change wouldn't work well as it would make a mess
> of output that uses no prefix (ie: emits at KERN_DEFAULT)
> with output that uses KERN_DEBUG
> That's the reason for _dbg and _dbg_cont.
Hmm, I don't get it. Is there any *existing* use of dprint in the hfplus code which is affected by your comment? Or is this another general stylistic comment? i.e. "this does not work in general"?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/