Re: arch/s390/lib/uaccess_pt.c: Missing breaks: ?

From: Joe Perches
Date: Mon Apr 15 2013 - 01:53:32 EST


On Mon, 2013-04-15 at 07:48 +0200, Heiko Carstens wrote:
> On Sat, Apr 13, 2013 at 11:06:14PM -0700, Joe Perches wrote:
> > Commit ea81531d ("s390/uaccess: fix page table walk")
> > added this code. It looks like it should have break;
> > for each case.
> no, the fallthrough is on purpose for each case statement.

Hi again. It might be useful to add /* fallthrough */
or some other comment showing it's intentional.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/