Re: [PATCH RFT] regulator: ab8500: Fix voltage_shift setting forAB8540_LDO_DMIC

From: Bengt JÃnsson
Date: Mon Apr 15 2013 - 05:12:48 EST

On 04/15/2013 10:36 AM, Axel Lin wrote:
The voltage_mask is 0xc0, thus we need to set voltage_shift = 6 to get correct
selector in get_voltage_sel and set_voltage_sel.

Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
The patch is correct. Voltage selection is done with 0xc0.

Acked-by: Bengt Jonsson <bengt.g.jonsson@xxxxxxxxxxxxxx>
Hi Bengt,
I don't have the datasheet. Can you confirm if this fix is correct?

BTW, can you also review a couple patches for ab8500 and ab8500-ext I sent a few
days ago? I ask this because now I have more patches that may depend on previous


drivers/regulator/ab8500.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c
index b81ff04..0a62ef9 100644
--- a/drivers/regulator/ab8500.c
+++ b/drivers/regulator/ab8500.c
@@ -1729,6 +1729,7 @@ static struct ab8500_regulator_info
.voltage_bank = 0x03,
.voltage_reg = 0x83,
.voltage_mask = 0xc0,
+ .voltage_shift = 6,

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at