Re: [alsa-devel] [PATCH 20/30] ASoC: samsung: convert to dmaengineAPI
From: Mark Brown
Date: Mon Apr 15 2013 - 07:04:56 EST
On Fri, Apr 12, 2013 at 09:27:27PM +0200, Lars-Peter Clausen wrote:
> I actually had a look at how the Samsung PCM driver a couple of days back,
> but I didn't fully grasp how things work with the secondary TX channel for
> the i2s driver and to make it work with the generic dmaengine PCM driver.
> The code handling this in the i2s driver seems to be rather messy with lots
> of ifs and elses. Also things would have would be a lot easier if the dt
> bindings had used two subnodes each with their own 'dmas' property.
Yeah, it's quite messy at the minute as it predates any subsystem
support for things like multiple DMA channels going into a single DAI on
an AP so it was having to do things it really shouldn't have done. What
ought to happen is that the driver gets refactored to use soc-pcm or
change to represent the mixer block as a CODEC, I think if that happens
then things ought to get easier.
Description: Digital signature