Re: [PROBLEM] perf requires python-devel to compile

[Pekka Enberg]

Hello,

On Tue, Apr 16, 2013 at 5:14 AM, Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>> The problem is that I didn't have python-devel package installed and
>> get-executable-or-default decides to error out instead of letting the
>> Makefile disable Python support.
>
> Right.  I think the get-executable-or-default should not error out in
> this case but just emit a warning and keep building.
>
> Does following patch fix your problem?
>
> -----------8<-------------8<-------------
> diff --git a/tools/perf/config/utilities.mak b/tools/perf/config/utilities.mak
> index 8ef3bd30a549..3b8036f8aca4 100644
> --- a/tools/perf/config/utilities.mak
> +++ b/tools/perf/config/utilities.mak
> @@ -177,7 +177,7 @@ $(if $($(1)),$(call _ge_attempt,$($(1)),$(1)),$(call _ge_attempt,$(2),$(1)))
>  endef
>  _ge_attempt = $(if $(get-executable),$(get-executable),$(_gea_warn)$(call _gea_err,$(2)))
>  _gea_warn = $(warning The path '$(1)' is not executable.)
> -_gea_err  = $(if $(1),$(error Please set '$(1)' appropriately))
> +_gea_err  = $(if $(1),$(warning Please set '$(1)' appropriately))
>
>  # try-cc
>  # Usage: option = $(call try-cc, source-to-build, cc-options, msg)

I considered this myself but I think this needs to fixed at a higher
level and keep the error out.

                        Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/