Re: [PATCH 24/32] dmaengine: ste_dma40: Supply full Device Tree parsing support

From: Arnd Bergmann
Date: Thu Apr 18 2013 - 07:07:58 EST


On Thursday 18 April 2013, Lee Jones wrote:
> + dma-channels = <0>; /* Zero means read from H/W. */

One more thing: I would not make this a magic value. Better make the property
optional and require it to be correct if present and autodetected if absent.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/