Re: [PATCH 24/32] dmaengine: ste_dma40: Supply full Device Tree parsing support

[Arnd Bergmann]

On Thursday 18 April 2013, Lee Jones wrote:
> You're right, I am a little confused by them.
> 
> I call them 'device type' because that's what they're called already.
> Grep for 'dma_dev_type'. This is the number which gets split into
> event group and line, like this:
> 
>         event_group = D40_TYPE_TO_GROUP(dev_type);
>         event_line = D40_TYPE_TO_EVENT(dev_type);
> 
> > and I would put that number first.
> 
> So you want me to switch that round so it looks like:
> 
>         dmas = <<phandle> <dev_type> <fixed_chan> <flags>;
> 
> Instead of what I have at the moment:
> 
>         dmas = <<phandle> <fixed_chan> <dev_type> <flags>;
> 
> Correct?

Yes, that's probably better and more in line with what the other
drivers do. You could also put the fixed_chan last if that helps.

I would still like to get a confirmation that we actually still
require the fixed channel assignment, since it's just used
in one driver, and that might only be needed for some buggy
hardware revision if we're lucky.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/