Re: [PATCH] e1000e: fix mismatch in mutex lock-unlock ine1000_reset_hw_82571()

From: Jeff Kirsher
Date: Fri Apr 19 2013 - 02:45:10 EST


On Thu, 2013-04-18 at 22:15 -0700, Alexey Khoroshilov wrote:
> If e1000_get_hw_semaphore_82574() succeed, it acquires swflag_mutex,
> otherwise it does not. But the returned value of
> e1000_get_hw_semaphore_82574() is ignored, so unlocking of
> swflag_mutex
> happens anyway.
>
> The patch fixes the issue by breaking reset if MIC ownership is not
> acquired.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>
> ---
> drivers/net/ethernet/intel/e1000e/82571.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)

Thanks Alexey, I have added your patch to my queue.

Attachment: signature.asc
Description: This is a digitally signed message part