Re: [PATCH] kref: minor cleanup

From: Greg KH
Date: Sat Apr 20 2013 - 18:31:12 EST


On Fri, Apr 19, 2013 at 09:27:20PM -0700, Anatol Pomozov wrote:
> >> -static struct kobject *kobject_get_unless_zero(struct kobject *kobj)
> >> +static struct kobject *__must_check kobject_get_unless_zero(
> >> + struct kobject *kobj)
> >
> > __must_check needs to be in the .h file, not the .c file.
>
> This function is static and defined in *.c. But I think the function
> should be declared in *.h as it might be useful for others. I'll
> resend patch tomorrow.

No, I was trying to give you a hint in that it is not needed because
this function is not exported, sorry for being vague.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/