Re: [PATCHv2 2/5] driver: serial: omap: prevent runtime PM for "no_console_suspend"

[Sourav Poddar]

Hi Felipe,
On Monday 22 April 2013 08:01 PM, Felipe Balbi wrote:
> Hi,
>
> On Mon, Apr 22, 2013 at 07:13:54PM +0530, Sourav Poddar wrote:
> > The driver manages "no_console_suspend" by preventing runtime PM
> > during the suspend path, which forces the console UART to stay awake.
> >
> > Signed-off-by: Sourav Poddar<sourav.poddar@xxxxxx>
> > ---
> >   drivers/tty/serial/omap-serial.c |    5 ++++-
> >   1 files changed, 4 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
> > index 08332f3..640b14e 100644
> > --- a/drivers/tty/serial/omap-serial.c
> > +++ b/drivers/tty/serial/omap-serial.c
> > @@ -1582,7 +1582,7 @@ static int serial_omap_runtime_suspend(struct device *dev)
> >   	struct uart_omap_port *up = dev_get_drvdata(dev);
> >   	struct omap_uart_port_info *pdata = dev->platform_data;
> >
> > -	if (!up)
> > +	if (!up || (!console_suspend_enabled&&  uart_console(&up->port)))
> >   		return -EINVAL;
> -EBUSY would be a better value for uart_console case, so this check
> should be splitted accordingly. Likewise on second hunk.
Ok. Will change in the next version.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/