Re: [PATCH 06/10] usb: musb: ux500: add device tree probing support

[Felipe Balbi]

Hi,

On Tue, Apr 23, 2013 at 05:27:10PM +0200, Arnd Bergmann wrote:
> > > > +Required properties:
> > > > + - compatible : Should be "stericsson,db8500-musb"
> > > > + - reg        : Offset and length of registers
> > > > + - interrupts : Interrupt; mode, number and trigger
> > > > + - mode       : One of; "host", "otg", or "peripheral"
> > > 
> > > I think we don't have any precedent for this combination of "mode" property
> > > and contents. You could either try to match ehci-omap.txt and do
> > 
> > there is dr_mode which other folks are using. Let's use the same thing.
> 
> On that topic, should we support the same property in am35x.c and 
> musbhsdma.c? They currently use an integer rather than a string.

certainly :) I also plan to add dr_mode support for dwc3.

-- 
balbi

Attachment: signature.asc
Description: Digital signature