RE: [tip:x86/efi2] efivars: efivar_entry API

[Seiji Aguchi]

It worked with this fix.
Thanks!

Seiji

> -----Original Message-----
> From: Matt Fleming [mailto:matt.fleming@xxxxxxxxx]
> Sent: Friday, April 26, 2013 10:55 AM
> To: Seiji Aguchi
> Cc: linux-kernel@xxxxxxxxxxxxxxx; mingo@xxxxxxxxxx; hpa@xxxxxxxxx; mjg59@xxxxxxxxxxxxx; tony.luck@xxxxxxxxx; jk@xxxxxxxxxx;
> teg@xxxxxxx; tglx@xxxxxxxxxxxxx; mikew@xxxxxxxxxx; linux-tip-commits@xxxxxxxxxxxxxxx
> Subject: Re: [tip:x86/efi2] efivars: efivar_entry API
> 
> On 26/04/13 15:25, Seiji Aguchi wrote:
> > Matt,
> >
> > Thanks.
> > With your patch, It works in case each entry is erased one by one as below.
> > # rm dmesg-efi-1
> > #rm dmesg-efi-2
> 
> How about if you add this to efi_pstore_erase_func()?
> 
> ---
> 
> diff --git a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c
> index b820593..393d63a 100644
> --- a/drivers/firmware/efi/efi-pstore.c
> +++ b/drivers/firmware/efi/efi-pstore.c
> @@ -166,6 +166,7 @@ static int efi_pstore_erase_func(struct efivar_entry *entry, void *data)
> 
>  	/* found */
>  	__efivar_entry_delete(entry);
> +	list_del(&entry->list);
>  	return 1;
>  }
> 
N‹§²æìr¸›yúèšØb²X¬¶ÇvØ^–)Þ{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü}©ž²ÆzÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹®w¥¢¸?™¨è­Ú&¢)ßf”ù^jÇy§m…á@A«a¶Úÿ0¶ìh®å’i