Re: [PATCH 4/4] memory_hotplug: use pgdat_resize_lock() when updatingnode_present_pages

From: Cody P Schafer
Date: Wed May 01 2013 - 18:51:14 EST


On 05/01/2013 03:48 PM, David Rientjes wrote:
On Wed, 1 May 2013, Cody P Schafer wrote:

Guaranteed to be stable means that if I'm a reader and pgdat_resize_lock(),
node_present_pages had better not change at all until I pgdat_resize_unlock().

If nothing needs this guarantee, we should change the rules of
pgdat_resize_lock(). I played it safe and went with following the existing
rules.


__offline_pages() breaks your guarantee.


Thanks for pointing that out. Seems I fixed online_pages() but missed __offline_pages().

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/