Re: [PATCH 1/1] Create megaraid ioctl device node

[Patrick Monnerat]

On 05/06/2013 04:23 PM, BjÃrn Mork wrote:
> "Patrick Monnerat" <Patrick.Monnerat@xxxxxxxxxxxxx> writes:
> >    Create ioctl device node for megaraid_sas driver. Let this node be
> > managed by udev. Fix a typo.
>
> Or maybe just simplify it all and use a misc device instead?  See how
> this is done in e.g. drivers/scsi/mpt3sas/mpt3sas_ctl.c or
> drivers/message/fusion/mptctl.c

Yes, could be done that way, But I want to retain compatibility with 
existing shell scripts doing things like:

DEVICE=/dev/megaraid_sas_ioctl_node
DEVICENAME=megaraid_sas_ioctl
DEVICEPERM=400
MAJOR=`grep "$DEVICENAME" /proc/devices | awk '{print $1}'`

if [ -n "$MAJOR" -a ! -e "$DEVICE" ]; then
    mknod "$DEVICE" c "$MAJOR" 0
    chmod "$DEVICEPERM" "$DEVICE"
fi

Snippets like this one appear both in open-source projects and Dell scripts.

Patrick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/