Re: [PATCH 1/2] leds: lp55xx: support dynamic channel settings in thedevice tree structure

From: Linus Walleij
Date: Tue May 07 2013 - 15:59:57 EST


On Tue, May 7, 2013 at 9:14 AM, Kim, Milo <Milo.Kim@xxxxxx> wrote:

> Currently, the LP55xx DT structure supports max 3 channels.
> However, LP5523 has max 9 channels and LP5562 has 4 channels.
> To enhance this constraint, the DT structure has been changed.
>
> (a) Use the child node for various channel settings instead of fixed array
> (b) Remove 'num_channel' property.
> This value can be retrieved by counting the children node.
> (c) 'chan-name' property supported
> (d) Documentation updates for LP5521 and LP5523
>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Gabriel Fernandez <gabriel.fernandez@xxxxxxxxxxxxxx>
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@xxxxxx>

This is looking very good to me.
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/