Re: [patch v6 6/8] sched: compute runnable load avg in cpu_load andcpu_avg_load_per_task

From: Alex Shi
Date: Mon May 13 2013 - 20:52:00 EST


On 05/13/2013 10:06 PM, Peter Zijlstra wrote:
>> > static void update_cpu_load_active(struct rq *this_rq)
>> > {
>> > + unsigned long load;
>> > +
>> > +#ifdef CONFIG_SMP
>> > + load = this_rq->cfs.runnable_load_avg;
>> > +#else
>> > + load = this_rq->load.weight;
>> > +#endif
>> > /*
>> > * See the mess around update_idle_cpu_load() / update_cpu_load_nohz().
> This just smells like you want a helper function... :-)

Yes, thanks for point out this!
>
> Also it doesn't apply anymore due to Paul Gortemaker moving some of this
> stuff about.

Will rebase on this. Thanks again! :)

--
Thanks
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/