Re: Build regressions/improvements in v3.10-rc1 (cris)

From: Geert Uytterhoeven
Date: Tue May 14 2013 - 08:06:57 EST


On Sun, May 12, 2013 at 10:44 PM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> drivers/video/console/fonts.c:71:2: error: #error No fonts configured.: 2 errors in 2 logs
> v3.10-rc1/cris/cris-allmodconfig v3.10-rc1/cris/cris-allyesconfig
>
> Fbdev issue?

This is caused by cris not using the generic drivers/Kconfig, and thus not
traversing drivers/video/console/Kconfig.
As the build system does traverse drivers/video/console/Makefile, fonts.c
is compiled with an inconsistent configuration.

Two solutions:
1. Add drivers/video/console/Kconfig to arch/cris/Kconfig,
2. Switch cris to drivers/Kconfig,

I prefer two, as this is what's done by all (except h8300) other
architectures. This will seriously broaden the scope of allmodconfig,
though, and require more fixes (e.g. missing <asm/vga.h>).

Note: The decision logic for compiling drivers/video/console/fonts.c is
overly complicated, and seems to be buggy for some stuff living
outside drivers drivers/video (drivers/media/platform/vivi.c and
drivers/staging/media/solo6x10/solo6x10-enc.c). I think this should
be resolved in Kconfig logic, using a new FONT_SUPPORT
symbol (FONTS is already taken).

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/