Re: [PATCH V2 2/3] Documentation: virtio: Add emergency write(emerg_wr) config register in virtio console.

From: Amit Shah
Date: Wed May 15 2013 - 01:31:14 EST


On (Wed) 15 May 2013 [13:59:29], Rusty Russell wrote:
> Pranavkumar Sawargaonkar <pranavkumar@xxxxxxxxxx> writes:
> > Hi Rusty,
> >
> > On 13 May 2013 08:22, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
> >> Pranavkumar Sawargaonkar <pranavkumar@xxxxxxxxxx> writes:
> >>> Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@xxxxxxxxxx>
> >>> Signed-off-by: Anup Patel <anup.patel@xxxxxxxxxx>
> >>> ---
> >>> Documentation/virtual/virtio-spec.txt | 8 +++++++-
> >>> 1 file changed, 7 insertions(+), 1 deletion(-)
> >>
> >> OK, I applied this to the lyx master, with three changes:
> >> 1) Changed "filed" to "field".
> >> 2) Added ", or even acknowledging the feature" after "without
> >> initializing virtio queues".
> >> 3) Added an initial point to the Device Initialization section:
> >>
> >> 1. If the VIRTIO_CONSOLE_F_EMERG_WRITE feature is offered, the
> >> emerg_wr field of the configuration can be written at any time. Thus
> >> it should work for very early boot debugging output as well as
> >> catastophic OS failures (eg. virtio ring corruption).
> >
> > Thanks for applying this patch.
> > Have you also applied first patch ([PATCH V2 1/3] virtio: console: Add
> > emergency writeonly register to config space)
> > with this? (https://lkml.org/lkml/2013/5/6/169)
>
> Would like Amit's Ack, since he's de-facto console maintainer.

I've been away, and am reviewing the discussions here. Expect a
response later today.

Thanks,

Amit
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/