Re: [PATCH v2 net-next 1/4] net: implement support for low latencysocket polling

From: Joe Perches
Date: Mon May 20 2013 - 04:30:01 EST


On Mon, 2013-05-20 at 00:54 -0700, David Miller wrote:
> From: Eliezer Tamir <eliezer.tamir@xxxxxxxxxxxxxxx>
[]
> > {
> > struct socket *sock;
> > + unsigned int poll_result;
>
> Please order local variable declarations from longest line to
> shortest line.

reverse christmas tree doesn't seem especially valuable or
sensible for automatics.

I'd rather order by first use or even alphabetical, especially
with long lists of automatics.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/