Re: [PATCH v2 net-next 1/4] net: implement support for low latencysocket polling

[Eliezer Tamir]

On 20/05/2013 10:54, David Miller wrote:
> From: Eliezer Tamir <eliezer.tamir@xxxxxxxxxxxxxxx>
> Date: Sun, 19 May 2013 13:25:33 +0300
>
> > +#else /* CONFIG_INET_LL_RX_FLUSH */
> > +
> > +#define sk_valid_ll(sk) 0
> > +#define sk_poll_ll(sk, nonblock) do {} while (0)
> > +#define skb_mark_ll(napi, skb) do {} while (0)
> > +#define sk_mark_ll(sk, skb) do {} while (0)
>
> Make these inline functions too, so that even if
> CONFIG_INET_LL_RX_POLL is disabled, the arguments and return values
> are still properly type checked.

Is this what you had in mind?

static inline bool sk_valid_ll(struct sock *sk)
{
	return 0;
}

static inline bool sk_poll_ll(struct sock *sk, int noblock)
{
	return 0;
}

static inline void skb_mark_ll(struct sk_buff *skb, struct napi_struct 
*napi)
{
}

static inline voiv sk_mark_ll(struct sock *sk, struct sk_buff *skb)
{
}

would you like me to resend the whole set or just this patch?

Thanks,
Eliezer
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/