Re: [PATCH] Revert "x86-64, init: Do not set NX bits on non-NX capablehardware"

[H. Peter Anvin]

On 05/20/2013 11:23 AM, Michal Hocko wrote:
> On Mon 20-05-13 10:21:09, Linus Torvalds wrote:
>> On Mon, May 20, 2013 at 9:43 AM, Michal Hocko <mhocko@xxxxxxx> wrote:
>>>
>>> The configuration has been posted in the referenced thread:
>>> https://lkml.org/lkml/2013/5/14/398
>>
>> Hmm. That's a regular intel i5 Sandybridge CPU. Which certainly has NX.
>>
>> Hmm. secondary_startup_64 isn't __initcode, is it? I think it's used
>> for resuming the other CPU's too and for CPU hotplug. Yes/no?
>>
>> If so early_pmd_flags shouldn't be __initdata, I think.
>>
>> Michal, does it work if you don't do the revert, but just remove the
>> __initdata instead?
> 
> Right you are! The following patch on top of your tree fixes the
> problem. Thanks a lot. I will leave the proper changelog to somebody who
> is more familiar with the area but AFAIU the real problem is that
> early_pmd_flags is no longer available beacause the section is gone.
> 

I'll write it up and send a pull request to Linus.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/