Re: [PATCH] ASoC: Add support for BCM2708

[Stephen Warren]

On 05/22/2013 10:08 AM, Florian Meier wrote:
> On 22.05.2013 17:22, Stephen Warren wrote:
>> On 05/22/2013 08:10 AM, Florian Meier wrote:
>>> This driver adds support for digital audio (I2S)
>>> for the BCM2708 SoC that is used by the
>>> Raspberry Pi. External audio codecs can be
>>> connected to the Raspberry Pi via P5 header.
>>>
>>> It relies on cyclic DMA engine support for BCM2708
>>> that is not included in this patch.
>>
>> This SoC is actually the BCM2835, so the files should be named for that.
> 
> Actually, I changed the name several times and in the end I sticked to
> https://github.com/raspberrypi/linux/issues/22
> but if you think it is better to use BCM2835 I am happy to agree with
> you and change it.
> 
>> Upstream only uses device tree for BCM2835. Does this driver support DT?
>> Where is the DT binding definition file?
> 
> I have not accomplished to use the mainline kernel and DT with the
> Raspberry Pi. Do you have any introductive information about how to do this?

Oh, so is this patch intended for the downstream Raspberry Pi Foundation
kernel, or the upstream kernel?

The fact you haven't run it on the upstream kernel implies that you
intend the patch to be applied to the downstream kernel.

The fact you sent the driver to all the upstream mailing lists implies
that you intend the patch to be applied to the upstream kernel.

BTW, I wrote a Google+ post on using the upstream kernel on the Pi:
https://plus.google.com/101715070573995136397/posts/gWkwrfNfYVm

>> I assume you're planning on sending the DMA driver upstream too? I guess
>> this driver isn't useful without it.
> 
> I would like to, but it only supports cyclic DMA. Should I send it
> upstream anyway? In case you are interested:

I don't think that limitation would stop it being useful upstream;
somebody else might always enhance it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/