Re: [PATCH v2 2/2] firmware: Avoid deadlock of usermodehelper lock at shutdown

From: Ming Lei
Date: Wed May 22 2013 - 22:41:30 EST


On Thu, May 23, 2013 at 12:28 AM, Takashi Iwai <tiwai@xxxxxxx> wrote:
> When a system goes to reboot/shutdown, it tries to disable the
> usermode helper via usermodehelper_disable(). This might be blocked
> when a driver tries to load a firmware beforehand and it's stuck by
> some reason. For example, dell_rbu driver loads the firmware in
> non-hotplug mode and waits for user-space clearing the loading sysfs
> flag. If user-space doesn't clear the flag, it waits forever, thus
> blocks the reboot, too.
>
> As a workaround, in this patch, the firmware class driver registers a
> reboot notifier so that it can abort all pending f/w bufs before
> issuing usermodehelper_disable().
>
> Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>

Acked-by: Ming Lei <ming.lei@xxxxxxxxxxxxx>

thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/