Re: [PATCH mainline] lib: make iovec obj instead of lib

From: Rusty Russell
Date: Thu May 23 2013 - 03:46:40 EST


Randy Dunlap <rdunlap@xxxxxxxxxxxxx> writes:
> when CONFIG_VMWARE_VMCI=m:
>
> ERROR: "memcpy_toiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined!
> ERROR: "memcpy_fromiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined!
>
> Changing iovec.o from lib-y to obj-y fixes the build errors.

Acked-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>

Thanks!
Rusty.

> ---
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> Fix build error io vmw_vmci.ko by chaning iovec.o from lib-y to
> obj-y.
>
> ERROR: "memcpy_toiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined!
> ERROR: "memcpy_fromiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined!
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> ---
> lib/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- mmotm-2013-0522-1640.orig/lib/Makefile
> +++ mmotm-2013-0522-1640/lib/Makefile
> @@ -9,7 +9,7 @@ endif
>
> lib-y := ctype.o string.o vsprintf.o cmdline.o \
> rbtree.o radix-tree.o dump_stack.o timerqueue.o\
> - idr.o int_sqrt.o extable.o iovec.o \
> + idr.o int_sqrt.o extable.o \
> sha1.o md5.o irq_regs.o reciprocal_div.o argv_split.o \
> proportions.o flex_proportions.o prio_heap.o ratelimit.o show_mem.o \
> is_single_threaded.o plist.o decompress.o kobject_uevent.o \
> @@ -23,7 +23,7 @@ lib-y += kobject.o klist.o
>
> obj-y += bcd.o div64.o sort.o parser.o halfmd4.o debug_locks.o random32.o \
> bust_spinlocks.o hexdump.o kasprintf.o bitmap.o scatterlist.o \
> - gcd.o lcm.o list_sort.o uuid.o flex_array.o clz_ctz.o\
> + gcd.o lcm.o list_sort.o uuid.o flex_array.o clz_ctz.o iovec.o \
> bsearch.o find_last_bit.o find_next_bit.o llist.o memweight.o kfifo.o
> obj-y += string_helpers.o
> obj-$(CONFIG_TEST_STRING_HELPERS) += test-string_helpers.o
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/