Re: [PATCH] drivers: mfd: tps65912: Convert to use devm_kzalloc

[Lee Jones]

> > There is no need to call kfree while using devm_kzalloc,
> > remove it from *_device_init function.
> >
> > Signed-off-by: Leon Romanovsky <leon@xxxxxxx>
> > ---
> >  drivers/mfd/tps65912-core.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> To be honest the whole tps65912 looks strange to me.
> For example,  kfree(tps65912) calls all over the code.
> 
> tps65912_i2c_probe allocates tps65912 struct, but tps65912_device_exit
> releases it.

Yes, this is expected.

tps65912_[spi|i2c]_remove() both call tps65912_device_exit() which in
turn frees tps65912. Saves duplicating code.

I'll clean thinks up a little, so this is less confusing.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/