Re: [PATCH] kernel/debug/kdb: code enhancement for 3 areas.

[Anton Vorontsov]

On Thu, May 16, 2013 at 07:25:46PM +0800, Chen Gang wrote:
> Delete waste '{' for 'case' statement.
> 
> For the return variable 'long res' in function kdb_task_state_string(),
> neither it matches the function return type 'unsigned long', nor is
> suitable as a flag variable to make 'or' operation. So use 'unsigned
> long' instead of 'long'.
> 
> If "case 'A'" happen in function kdb_task_state_string(), can return
> ~0UL directly to save the useless looping.
> 
> Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx>

If anything, these should be 3 separate patches...

Thanks!

Anton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/