Re: [PATCH 1/7] staging/silicom/bypasslib: Reformat comments

[Joe Perches]

On Thu, 2013-05-23 at 13:51 -0700, Lisa Nguyen wrote:
> Resolved the C99 comment style issue by reformatting existing comments 
> to meet kernel coding standards in bp_ioctl.h
[]
> diff --git a/drivers/staging/silicom/bypasslib/bp_ioctl.h b/drivers/staging/silicom/bypasslib/bp_ioctl.h
[]
> -#define BP_CAP                   0x01	//BIT_0
[...]
> +#define BP_CAP                   0x01	/* BIT_0 */

Better to use the more self-documenting

#define BP_CAP		BIT(0)

etc...  with out any comment at all.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/