Re: [PATCH v3 part1 1/4] sg_io: pass request_queue to blk_verify_command

[Paolo Bonzini]

Il 24/05/2013 09:36, James Bottomley ha scritto:
> On Thu, 2013-05-23 at 15:58 +0200, Paolo Bonzini wrote:
>> Adjust the blk_verify_command function to let it look at per-queue
>> data.  This will be done in the next patch.
> 
> This is not a bug fix.  This is an enabler for your complex and to my
> mind dubious rework of the SG_IO command filter.  I'm running out of
> ways to say please don't mix bug fixes with features, because this
> redesignating of the original patch set as part 1 and parts 2,3 doesn't
> satisfy the requirement.

I made it part 1/2/3 because parts 2/3 depend on part 1.  It makes
dependency tracking easier, at least in my mind.

If you have another solution that does not require passing request_queue
to blk_verify_command, I'm all ears.

> Does anyone in the real world actually care about this bug?

Yes, or I would move on and not waste so much time on this.

Paolo

> because if
> not perhaps we can just remove the confusion and consider this as a
> feature set.  If there's someone who actually cares, please lets just do
> the bug fix first and argue about the feature later.
> 
> James
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/