Re: [RESEND PATCH] pwm: pwm-atmel-tcb: pinctrl support

[boris brezillon]

On 23/05/2013 21:35, Thierry Reding wrote:
> On Thu, May 23, 2013 at 06:38:52PM +0200, Boris BREZILLON wrote:
> > Hello,
> >
> > I sent a patch 1 month ago to add pinctrl support to pwm-atmel-tcb
> > driver and didn't get any review.
> >
> > Could you take a look?
> >
> > This patch adds pins request for the pwm device exposed by the TC
> > block using the pinctrl subsystem.
> I was actually looking at this a few days back and thought I remembered
> this being handled in the core now. There was some discussion about this
> back in January (?) as far as I remember. I just verified that indeed
> there is code in the driver core code to do this. See commit:
>
> 	ab78029ecc347debbd737f06688d788bd9d60c1d  drivers/pinctrl: grab default handles from device core
>
> Are you sure this is really necessary in the driver?
No.

Thanks for pointing this commit out (I didn't notice the default handles 
were grabbed
from device core).

I'll test it without this patch.

Best Regards,
Boris
> Thierry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/