Re: [PATCH] tracing: Fix file mode of free_buffer

[Steven Rostedt]

On Tue, 2013-05-28 at 13:14 -0700, David Sharp wrote:
> On Tue, May 28, 2013 at 12:34 PM, Vaibhav Nagarnaik
> <vnagarnaik@xxxxxxxxxx> wrote:
> > On Sun, May 26, 2013 at 1:52 AM, Wang YanQing <udknight@xxxxxxxxx> wrote:
> >> Commit 4f271a2a60c748599b30bb4dafff30d770439b96
> >> (tracing: Add a proc file to stop tracing and free buffer)
> >> implement a method to free up ring buffer in kernel memory
> >> in the release code path of free_buffer's fd.
> >>
> >> Then we don't need read/write support for free_buffer,
> >> indeed we just have a dummy write fop, and don't implement read fop.
> >>
> >> So the 0200 is more reasonable file mode for free_buffer than
> >> the current file mode 0644.
> >>
> >> Signed-off-by: Wang YanQing <udknight@xxxxxxxxx>
> >
> > Acked-by: Vaibhav Nagarnaik <vnagarnaik@xxxxxxxxxx>
> 
> Acked-by: David Sharp <dhsharp@xxxxxxxxxx>
> 
> >

Thanks guys,

As this isn't that big of a deal, I'm going to just queue this for 3.11.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/