Re: [PATCH 10/12] ipu_idmac: re-use dma_cookie_status()

[Shawn Guo]

On Mon, May 27, 2013 at 03:14:40PM +0300, Andy Shevchenko wrote:
> It's better to use generic dma_cookie_status() that allows user to get standard
> possible return codes independently of the DMAC driver in charge.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Cc: Shawn Guo <shawn.guo@xxxxxxxxxx>

Acked-by: Shawn Guo <shawn.guo@xxxxxxxxxx>

> ---
>  drivers/dma/ipu/ipu_idmac.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
> index d39c2cd..608d4a2 100644
> --- a/drivers/dma/ipu/ipu_idmac.c
> +++ b/drivers/dma/ipu/ipu_idmac.c
> @@ -1593,10 +1593,7 @@ static void idmac_free_chan_resources(struct dma_chan *chan)
>  static enum dma_status idmac_tx_status(struct dma_chan *chan,
>  		       dma_cookie_t cookie, struct dma_tx_state *txstate)
>  {
> -	dma_set_tx_state(txstate, chan->completed_cookie, chan->cookie, 0);
> -	if (cookie != chan->cookie)
> -		return DMA_ERROR;
> -	return DMA_SUCCESS;
> +	return dma_cookie_status(chan, cookie, txstate);
>  }
>  
>  static int __init ipu_idmac_init(struct ipu *ipu)
> -- 
> 1.8.2.rc0.22.gb3600c3
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/