Re: [PATCH v1 1/3] PM / AVS: SmartReflex: disable errgen before vpbound disable

[Kevin Hilman]

Andrii Tseglytskyi <andrii.tseglytskyi@xxxxxx> writes:

[...]

>>> Signed-off-by: Vincent Bour <v-bour@xxxxxx>
>>> Signed-off-by: Leonardo Affortunati <l-affortunati@xxxxxx>
>>> Signed-off-by: Nishanth Menon <nm@xxxxxx>
>>> Signed-off-by: Andrii.Tseglytskyi <andrii.tseglytskyi@xxxxxx>
>>  From Documentation/SubbmittingPatches:
>>
>>     "If a person was not directly involved in the preparation or handling
>>     of a patch but wishes to signify and record their approval of it then
>>     they can arrange to have an Acked-by: line added to the patch's
>>     changelog."
>>
>> Are all of the tags above co-authors or on the delivery path?  I suspect
>> an Acked-by or Reviewed-by is more appropriate here.

[...]

> This patch was developed by Nishanth, he is the author of the code.
> Patch is the result of 2-week debug session. Vincent, Leonardo and
> Nishanth were involved to that debug session.
> My contribution to this patch - is sending it to upstream, no more
> than this.
> Could you please suggest - who should remain in Signed-offs ?

Nishanth as the author, and you since you're on the delivery path.

If Vincent & Leonardo should be considered as co-authors, then their
signoffs are fine, otherwise they should be reviewed-by or acked-by.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/