Improving or replacing snd_printk()

From: Alan Stern
Date: Wed May 29 2013 - 15:28:08 EST


Takashi:

Messages produced by snd_printk() aren't as informative as they could
be -- especially when CONFIG_SND_VERBOSE_PRINTK isn't enabled, which is
the case on most systems.

The routine uses printk() rather then dev_dbg(), dev_info(), or
dev_err(). As a result, the messages don't say what driver or device
is involved. We just get something like:

[15919.883604] cannot submit urb (err = -18)

That's not much help to anybody. If you didn't know what an urb was,
you wouldn't even realize that this referred to a USB device. And if
you had multiple USB audio devices, you wouldn't know which one it
referred to.

Has there been any thought of improving snd_printk(), or even better,
changing the call sites to use the dev_*() routines instead?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/