Re: [PATCH v2 1/2] clk: Disable unused clocks after deferred probingis done

From: Saravana Kannan
Date: Wed May 29 2013 - 21:55:58 EST


On 05/29/2013 12:51 AM, Mike Turquette wrote:
Quoting Saravana Kannan (2013-05-15 21:34:03)
On 05/09/2013 11:35 AM, Saravana Kannan wrote:
With deferred probing, late_initcall() is too soon to declare a clock as
unused. Wait for deferred probing to finish before declaring a clock as
unused. Since deferred probing is done in late_initcall(), do the unused
check to late_initcall_sync.

Signed-off-by: Saravana Kannan <skannan@xxxxxxxxxxxxxx>
---
drivers/clk/clk.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index fe4055f..5ecb64c 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -534,7 +534,7 @@ static int clk_disable_unused(void)

return 0;
}
-late_initcall(clk_disable_unused);
+late_initcall_sync(clk_disable_unused);

/*** helper functions ***/

Mike,

Thoughts? Picking it up? Removing the existing auto-disable code (I
think they are still useful)?


Hi Saravana,

I've taken this into clk-next for testing.

Regards,
Mike


Thanks.

-Saravana
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/