Re: [PATCH] timer: Fix jiffies wrap behavior of round_jiffies*()

[Bart Van Assche]

On 05/30/13 01:01, Andrew Morton wrote:
> On Tue, 21 May 2013 20:43:50 +0200 Bart Van Assche <bart.vanassche@xxxxxxxxx> wrote:
>
> > Make sure that the round_jiffies*() functions return a time that is
> > in the future when the jiffies counter is about to wrap.
>
> Actually "when the jiffies counter has recently wrapped".
>
> I assume this was found by inspection?

Hello Andrew,

You are correct, this was found via source code inspection. I started 
reviewing the round_jiffies*() implementation because I was chasing a 
bug in a kernel driver using one of these functions.

> > -		return original;
> > -	return j;
> > +	return time_is_after_jiffies(j) ? j : original;
> >   }
>
> Your email client mangles patches, btw.

Sorry. Will take more care in the future.

Bart.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/