Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

From: Ingo Molnar
Date: Fri May 31 2013 - 05:27:25 EST



* KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxx> wrote:

> >> I'm unhappy you guys uses offensive word so much. Please cool down all
> >> you guys. :-/ In fact, _BOTH_ the behavior before and after Cristoph's
> >> patch doesn't have cleaner semantics.
> >
> > Erm, this feature _regressed_ after the patch. All other concerns are
> > secondary. What's so difficult to understand about that?
>
> Because it is not new commit at all. Christoph's patch was introduced
> 10 releases before.

That's indeed sad - resource limits are not typically tested by apps. The
lack of Cc:s to people affected also helped hide the effects of the
change.

> $ git describe bc3e53f682
> v3.1-7235-gbc3e53f
>
> If we just revert it, we may get another and opposite regression report.
> I'm worried about it. Moreover, I don't think discussion better fix is
> too difficult for us.

Sure, I agree that a fix is generally better.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/