Re: [PATCH v2] drivers/base: Use attribute groups to create sysfsmemory files

From: Cody P Schafer
Date: Fri May 31 2013 - 17:46:08 EST


On 05/31/2013 01:31 PM, Nathan Fontenot wrote:
Update the sysfs memory code to create/delete files at the time of device
and subsystem registration.

The current code creates files in the root memory directory explicitly through
the use of init_* routines. The files for each memory block are created and
deleted explicitly using the mem_[create|delete]_simple_file macros.

This patch creates attribute groups for the memory root files and files in
each memory block directory so that they are created and deleted implicitly
at subsys and device register and unregister time.

This did necessitate moving the register_memory() updating it to set the
dev.groups field.

Signed-off-by: Nathan Fontenot <nfont@xxxxxxxxxxxxxxxxxx>

Please cc me on responses/comments.

v2: refreshed the patch, previous version was corrupted. There is no difference
otherwise between this patch and the previous one sent out.

Still looks broken. Tabs have been converted into spaces, and the top of the patch is whitespace padded to 80 characters.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/