[PATCH 0/2] PM / Runtime: Rework the "runtime idle" helper routine (was: Re: [PATCH RFC] PM / Runtime: Rework the "runtime idle" helper routine)
From: Rafael J. Wysocki
Date: Sun Jun 02 2013 - 17:46:33 EST
On Thursday, May 30, 2013 01:08:08 PM Alan Stern wrote:
> On Thu, 30 May 2013, Rafael J. Wysocki wrote:
> > > Since you're making this change, wouldn't it be a good idea to adopt
> > > Mika's original suggestion and turn on the RPM_AUTO bit in rpmflags
> > > when the use_autosuspend flag is set?
> > I'm not actually sure. It can be done, but I'd prefer to do that as a separate
> > change in any case.
> That makes sense.
> > > What about cases where the runtime-idle callback does
> > > rpm_schedule_suspend or rpm_request_suspend? You'd have to make sure
> > > that it returns -EBUSY in such cases. Did you audit for this?
> > As far as I could.
> > I'm not worried about the subsystems modified by this patch, because the
> > functionality there won't change (except for PCI, that is).
> Right. The subsystems that _aren't_ modified are the ones to worry
> about -- like the USB callback. They are the ones where the behavior
> might change.
OK, this time I think I've caught all of them. :-)
I've retained the ACKs and Reviewed-by tags in [1/2], because it only makes
more changes in addition to the previously ACKed ones. The PCI changeset
has been updated and [2/2] is the documentation update.
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/