On Jun 02 Greg Kroah-Hartman wrote:On Mon, Jun 03, 2013 at 12:27:49AM +0200, Stefan Richter wrote:Although all in-tree drivers are being converted to the new methods,
support for the old methods is left in place for the time being, aiming
to avoid conflicts if/when new drivers are being merged into the
mainline via other trees.
Are there other firewire drivers in other trees in linux-next right now?
If not, I'd just recommend converting everything over and not using the
old functions at all. Especially as there really isn't that many
firewire drivers, and new ones are pretty rare these days, right?
I think there is none in -next at the moment. But Sakamoto-san posted an
RFC just two days ago:
This is one of two(?) drivers on which he is currently working on; the
other one is the one which is going to need the new id argument
in .probe(). And then there is another person working on yet another
sound/firewire/ driver, but upstreaming of that driver might take a
little more time for some more integration steps, from what I heard.
So, alternatively I could fold "firewire: remove support of
fw_driver.driver.probe and .remove methods" into this one and commit it to
a stable topic branch in linux1394.git (to be merged early after 3.10),
and the audio driver developers could pull this topic branch if they want
to and when they want to.
Other than that, your patch looks good.
Thanks for review.