Re: [PATCH] Modify UEFI anti-bricking code
From: Matthew Garrett
Date: Mon Jun 03 2013 - 10:59:11 EST
On Mon, 2013-06-03 at 13:17 +0100, Matt Fleming wrote:
> Do we really want to drop this hunk? The point of this code was to
> inform firmware vendors that their implementation is returning funky
> results, and that they should look into why it's doing that.
We're not doing anything with that information now, and I don't think we
can do anything meaningful with it - some implementations report the
maximum size as the maximum supported by the implementation, and some
report it as the maximum that can be written given the amount of space
currently available. So yeah, it's against the spec to report 0 here,
but any other value is equally useless to us, so it seems like something
we'd be complaining about for no reason.
> What's the origin of this guid? And should we be adding it to
It's a scratch guid that's randomly generated to avoid colliding with
any other guid - we want to avoid this ever being a real variable.
Matthew Garrett | mjg59@xxxxxxxxxxxxx