Re: [PATCH V3] mfd: replace strict_strtoul() with kstrtoul()

From: Lee Jones
Date: Tue Jun 04 2013 - 03:23:28 EST


On Tue, 04 Jun 2013, Jingoo Han wrote:

> The usage of strict_strtoul() is not preferred, because
> strict_strtoul() is obsolete. Thus, kstrtoul() should be
> used.
>
> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> Changes since v1:
> - Removed redundant variables 'u8 reg'.
> - Changed the type of 'user_value' from 'unsigned long' to 'u8'.
> - Replaced kstrtoul() with kstrtou8() to handle u8 variable.
> - Added Andy Shevchenko's Reviewed-by.
>
> Changes since v1:
> - Used return code from kstrtoul().
> - Changed the type of 'user_reg' from 'unsigned long' to 'u8'.
> - Replaced kstrtoul() with kstrtou8() to handle u8 variable.
>
> drivers/mfd/aat2870-core.c | 5 +++--
> drivers/mfd/ab3100-core.c | 28 ++++++++++------------------
> drivers/mfd/ab8500-debugfs.c | 2 +-
> 3 files changed, 14 insertions(+), 21 deletions(-)

Applied.

If Andy has any further comments, I'll replace the applied version
with any v3 patch which you send.

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/