Re: [RFC PATCH v1 4/8] zram: destroy all devices on error recoverypath in zram_init()

From: Dan Carpenter
Date: Tue Jun 04 2013 - 04:49:53 EST

Everyone stop putting RFC on their bugfixes! :P No one wants to
pre-review patches.

On Mon, Jun 03, 2013 at 11:42:16PM +0800, Jiang Liu wrote:
> On error recovery path of zram_init(), it leaks the zram device object
> causing the failure.

This is a real bug but the fix isn't right. The object causing the
failure has only been partially set up. And in some cases it has
been partially cleaned up, for example we could end up releasing
->queue twice.

The better way is to make create_device() clean up after itself
completely instead of only partly and sometimes.

dan carpenter

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at