Re: [PATCH v2 2/3] cpufreq: Remove unused function __cpufreq_driver_getavg

[Stratos Karafotis]

On 06/04/2013 08:19 AM, Viresh Kumar wrote:
> On 4 June 2013 01:18, Stratos Karafotis <stratosk@xxxxxxxxxxxx> wrote:
> > Calculation of frequency target in ondemand governor changed and it is
>
> s/frequency target/target frequency

I will change it also in 3/3 that I use the same.

> > independent from measured average frequency.
> >
> > Remove unused__cpufreq_driver_getavg function and getavg member from
> > cpufreq_driver struct. Also, remove the callback getavg in
> > acpi_cpufreq_driver.
> >
> > Signed-off-by: Stratos Karafotis <stratosk@xxxxxxxxxxxx>
> > ---
> >   drivers/cpufreq/Makefile       |  2 +-
> >   drivers/cpufreq/acpi-cpufreq.c |  5 -----
> >   drivers/cpufreq/cpufreq.c      | 12 ------------
> >   include/linux/cpufreq.h        |  6 ------
> >   4 files changed, 1 insertion(+), 24 deletions(-)
> >
> > diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
> > index 6ad0b91..aebd4ef 100644
> > --- a/drivers/cpufreq/Makefile
> > +++ b/drivers/cpufreq/Makefile
> > @@ -23,7 +23,7 @@ obj-$(CONFIG_GENERIC_CPUFREQ_CPU0)    += cpufreq-cpu0.o
> >   # powernow-k8 can load then. ACPI is preferred to all other hardware-specific drivers.
> >   # speedstep-* is preferred over p4-clockmod.
> >
> > -obj-$(CONFIG_X86_ACPI_CPUFREQ)         += acpi-cpufreq.o mperf.o
>
> Should this be done in 3/3 ?

acpi-cpufreq does not use mperf after 2/3. Why should we compile it with
CONFIG_X86_ACPI_CPUFREQ?
Do you want me to move the change in 3/3?

Thanks,
Stratos

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/