[PATCH] eCryptfs: Check return of filemap_write_and_wait during fsync

From: Tyler Hicks
Date: Wed Jun 05 2013 - 02:53:15 EST

Error out of ecryptfs_fsync() if filemap_write_and_wait() fails.

Signed-off-by: Tyler Hicks <tyhicks@xxxxxxxxxxxxx>
Cc: Paul Taysom <taysom@xxxxxxxxxxxx>
Cc: Olof Johansson <olofj@xxxxxxxxxxxx>

After giving Paul's patch one more look, I noticed that we were ignoring
filemap_write_and_wait()'s return value. I plan to push this patch along with
Paul's original patch.

fs/ecryptfs/file.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/fs/ecryptfs/file.c b/fs/ecryptfs/file.c
index 16f509d..a7abbea 100644
--- a/fs/ecryptfs/file.c
+++ b/fs/ecryptfs/file.c
@@ -295,7 +295,12 @@ static int ecryptfs_release(struct inode *inode, struct file *file)
static int
ecryptfs_fsync(struct file *file, loff_t start, loff_t end, int datasync)
- filemap_write_and_wait(file->f_mapping);
+ int rc;
+ rc = filemap_write_and_wait(file->f_mapping);
+ if (rc)
+ return rc;
return vfs_fsync(ecryptfs_file_to_lower(file), datasync);


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/