Re: [patch -v4 4/8] memcg: enhance memcg iterator to supportpredicates
From: Michal Hocko
Date: Wed Jun 05 2013 - 04:52:53 EST
On Wed 05-06-13 01:05:45, Tejun Heo wrote:
> Hey, Michal.
> On Wed, Jun 05, 2013 at 09:37:28AM +0200, Michal Hocko wrote:
> > Tejun, I do not have infinite amount of time and this is barely a
> > priority for the patchset. The core part is to be able to skip
> > nodes/subtrees which are not worth reclaiming, remember?
> > I have already expressed my priorities for inside skipping
> > decisions. You are just throwing "let's try a different way" handwavy
> > suggestions. I have no problem to pull the skip logic outside of
> > iterators if more people think that this is _really_ important. But
> > until then I take it as a really low priority that shouldn't delay the
> > patchset without a good reason.
> > So please try to focus on the technical parts of the patchset if you
> > want to help with the review. I really appreciate suggestions but please
> > do not get down to bike scheding.
> Well, so, I know I've been pain in the ass but here's the thing. I
> don't think you've been doing a good job of maintaining memcg. Among
> the code pieces that I look at, it really ranks very close to the
> bottom in terms of readability and general messiness.
Something, something, something, something and other similar things....
Is this really an argumentation. Comon' Tejun.
I _really_ do not let this into a flame and I will not respond to any
other emails that are not related to the patchset. I do not care and do
not have time for that!
> One of the core jobs of being a maintainer is ensuring the code stays
> in readable and maintainable state.
As you might know I am playing the maintainer role for around year and a
half and there were many improvemtns merged since then (and some faults
as well of course).
There is a lot of space for improvements and I work at areas as time
permits focusing more at reviews for other people are willing to do.
Please stop distracting from the main purpose of this discussion with
side tracks and personal things.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/