Re: [PATCH] cpufreq: prevent 'policy->cpus' become offline in __gov_queue_work()

From: Rafael J. Wysocki
Date: Wed Jun 05 2013 - 08:28:51 EST


On Wednesday, June 05, 2013 04:58:44 PM Michael Wang wrote:
> Hi, Viresh
>
> On 06/05/2013 04:53 PM, Viresh Kumar wrote:
> [snip]
> >> It was caused by the policy->cpus changed during the process of
> >> __gov_queue_work(), in other word, cpu offline happened.
> >>
> >> This patch will use get/put_online_cpus() to prevent the offline
> >> happen inside __gov_queue_work(), after applied the patch, the
> >> warning is gone as Jiri tested:
> >>
> >> Link: https://lkml.org/lkml/2013/6/5/88
> >>
> >> CC: "Rafael J. Wysocki" <rjw@xxxxxxx>
> >> CC: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> >> Reported-by: Borislav Petkov <bp@xxxxxxxxx>
> >> Reported-by: Jiri Kosina <jkosina@xxxxxxx>
> >> Tested-by: Jiri Kosina <jkosina@xxxxxxx>
> >> Signed-off-by: Michael Wang <wangyun@xxxxxxxxxxxxxxxxxx>
> >> ---
> >> drivers/cpufreq/cpufreq_governor.c | 3 +++
> >> 1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
>
> Thanks for your ack :)

Queued up for 3.10.

Thanks,
Rafael


--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/