Re: [PATCH] Modify UEFI anti-bricking code
From: Matt Fleming
Date: Wed Jun 05 2013 - 16:00:04 EST
On Wed, 05 Jun, at 04:08:39PM, Matthew Garrett wrote:
> On Wed, 2013-06-05 at 16:59 +0100, Matt Fleming wrote:
> > + /* clean DUMMY object */
> > + efi.set_variable(efi_dummy_name, &EFI_DUMMY_GUID, 0, 0, NULL);
> Hm. Actually, is that going to work? From the spec:
> If a preexisting variable is rewritten with different attributes,
> SetVariable()shall not modify the variable and shall return
> So I think we probably need to fix the attributes to NV|RT|BS for both
> this call and the one in query_variable_store. We should probably also
> only do the workaround if the NV bit is set in the original query.
Yeah, that looks wrong.
Joey, care to resend an updated patch?
Matt Fleming, Intel Open Source Technology Center
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/