Re: [PATCH] ethernet/arc/arc_emac - Add new driver

From: David Miller
Date: Thu Jun 06 2013 - 19:35:38 EST

From: Alexey Brodkin <Alexey.Brodkin@xxxxxxxxxxxx>
Date: Tue, 4 Jun 2013 16:21:50 +0400

> +{
> + struct arc_emac_priv *priv = netdev_priv(net_dev);
> + struct phy_device *phydev = priv->phy_dev;
> + u32 reg;
> +
> + int status_change = 0;

Do not add empty lines amongst the top-level variable declarations
of a function. Fix this in the entire driver, as needed.

> + netdev_warn(net_dev,
> + "Speed (%d) is not 10/100?\n", phydev->speed);

Functions calls on multiple lines must have the arguments
aligned properly on the second and subsequent lines, this

function(arg1, arg2,
arg3, arg4);

You must use the appropriate number of TAB and space characters
to achieve this proper column alignment, rather than only using
TAB characters as you have done here.

Audit and fix this in your entire driver.

> +static int arc_emac_get_settings(struct net_device *net_dev,
> + struct ethtool_cmd *cmd)

The argument indention rules above apply to function definitions
as well.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at