Re: [RFC PATCH v2, part3 07/11] PCI, xen-pcifront: use new PCIinterfaces to simplify implementation
From: Konrad Rzeszutek Wilk
Date: Fri Jun 07 2013 - 13:09:28 EST
On Sat, Jun 08, 2013 at 12:50:31AM +0800, Jiang Liu wrote:
> On 06/07/2013 11:38 PM, Konrad Rzeszutek Wilk wrote:
> > On Fri, Jun 07, 2013 at 10:50:24AM -0400, Konrad Rzeszutek Wilk wrote:
> >> On Thu, May 16, 2013 at 11:50:55PM +0800, Jiang Liu wrote:
> >>> Use new PCI interfaces to simplify xen-pcifront implementation:
> >>> 1) Use pci_create_root_bus() instead of pci_scan_bus_parented()
> >>> because pci_scan_bus_parented() is marked as __deprecated.This
> >>> also gets rid of a duplicated call of pci_bus_start_devices().
> >>> 2) Use pci_stop_root_bus() and pci_remove_root_bus() instead of
> >>> open-coded private implementation.
> >>> 3) Use pci_set_host_bridge_release() to release data structures
> >>> associated with PCI root buses.
> >>> 4) Use pci_bus_get()/pci_bus_put() to manage PCI root bus reference
> >>> count.
> >>> This is also a preparation for coming PCI bus lock enhancement.
> > With this patch from :
> > Merge branch 'pci_lock_v3' of https://github.com/jiangliu/linux into testing
> > it blows up when detaching the device.
> Hi Konrad,
> Thanks for testing! According to the log messages, this issue should
> be related to pci bus reference counter management. Seems we have done
> an extra(unbalanced) release of pci bus device.
> Will investigate it tomorrow!
That is quite commendable that you are willing to look over this on
the weekend but I am not going to be able to rerun this test until
some time in the week. You could enjoy the weekend and just look at
this during the week.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/